Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes changes so that this crate it can be used as a library (eg rust-minidump/minidump-writer#21 (comment)).
failure
withanyhow
.failure
has been unmaintained for several years,anyhow
is one of the maintained alternatives. This change is intended as temporary, as IMO the errors in this crate should usethiserror
, or just manually defined errors, as it makes library usage easier by not using string errors for everything, but made sense for a binary application.clap
andsimplelog
behind acli
feature flag, these dependencies are only used when used as a binary, crates that depend on this as a library don't need them and thus should not compile them. To preserve backwards compatibility forcargo install
this feature is made default, so library users will need to explicitly opt-out.http
feature. This removes several heavy dependencies only used for retrieving symbols from remote symbol stores, in the use case that motivated this PR linked above, this functionality is not needed and only adds compile time for no benefit. Again, this feature is enabled by default for backwards compatibility.reqwest
's use of native-tls withrustls
, simplifying the build whenhttp
is enabled. I frankly despise OpenSSL and all of the aggravating problems that come with it,rustls
is a drop-in replacement that completely avoids all of those aggravations. This change is obviously due to my personal bias, I can back it out if requested.Resolves: #253