Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more SDK app contexts with multiple values for each variable #7447

Closed
jaredlockhart opened this issue Jun 22, 2022 · 2 comments
Closed

Comments

@jaredlockhart
Copy link
Collaborator

jaredlockhart commented Jun 22, 2022

The operator short circuiting in different JEXL runtimes can cause the right hand side of an || operation to not be evaluated at all, which means if they appear in our targeting JEXL expressions and the supplied app contexts don't include values that will cause the left hand operand to evaluate to false we'll never test the right hand side. We should modify our supplied test app contexts here to include more possible values, at the very least for the values in

              "custom_targeting_attributes": 
              {
                "is_already_enrolled": true,
                "days_since_update": 1,
                "days_since_install": 1
              }

I think we can get away with each of false|true for boolean fields and 0|1 for integer fields. Let's try that and we can evaluate further later if we find something more.

┆Issue is synchronized with this Jira Task

@data-sync-user
Copy link
Collaborator

➤ Benjamin Forehand Jr. commented:

This should be done after https://mozilla-hub.atlassian.net/browse/EXP-2553 ( https://mozilla-hub.atlassian.net/browse/EXP-2553|smart-link )

@jaredlockhart
Copy link
Collaborator Author

Actually through testing I determined this won't actually force the evaluator to evaluate both sides of an || clause, closing this in favour of #7464

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants