Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Evaluate JEXL subexpressions in desktop integration tests #7464

Open
jaredlockhart opened this issue Jun 28, 2022 · 2 comments
Open

Evaluate JEXL subexpressions in desktop integration tests #7464

jaredlockhart opened this issue Jun 28, 2022 · 2 comments
Labels

Comments

@jaredlockhart
Copy link
Collaborator

jaredlockhart commented Jun 28, 2022

As a followup to #7449 we discovered that while we can evaluate subexpressions in the Rust JEXL evaluator and meaningfully determine if they include undefined variables or invalid comparisons, we can't do the same on desktop without changes to the JS JEXL evaluator.

After we make the following changes:

mozilla/mozjexl#25

And get them landed into MC:

https://bugzilla.mozilla.org/show_bug.cgi?id=1773388#c2

then we can add the subexpression evaluation to desktop the way we do for the sdk.

┆Issue is synchronized with this Jira Task

@jaredlockhart
Copy link
Collaborator Author

Bump

@jaredlockhart
Copy link
Collaborator Author

Still worth doing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant