-
Notifications
You must be signed in to change notification settings - Fork 193
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix #7440 feat(nimbus): migrate sticky targeting configs #7446
Conversation
89aee1f
to
03ccecb
Compare
"query_result": { | ||
"id": 15734423, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why is this changed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh vscode moved the indentation around
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The actual change was trying to get the custom_targeting_attributes
to have the expected types, ie integers and bools, rather than strings. But it turns out this whole thing gets parsed and expects only string types. But you can pass in custom_targeting_attributes
separately into the helper encoded as JSON with the actual types, so I ended up just taking it out of here entirely.
Because * Now that the sticky targeting clause is moved right into the NimbusExperiment targeting method * There's no need for the sticky clause to be included in individual targeting configs This commit * Removes the sticky clauses from all desktop and mobile targeting configs * Removes the now redundant 'pip_never_used_sticky' targeting config and migrates experiments that used it to 'pip_never_used' * Migrates all existing experiments that use a previously sticky targeting config to have is_sticky=True
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! 🚀
The desktop sticky migration stuff looks good to me. r=dmose |
Because
This commit