Update @testing-library/dom and @testing-library/react #3648
Conversation
Bumps [@testing-library/react](https://github.com/testing-library/react-testing-library) from 13.4.0 to 14.0.0. - [Release notes](https://github.com/testing-library/react-testing-library/releases) - [Changelog](https://github.com/testing-library/react-testing-library/blob/main/CHANGELOG.md) - [Commits](testing-library/react-testing-library@v13.4.0...v14.0.0) --- updated-dependencies: - dependency-name: "@testing-library/react" dependency-type: direct:development update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
Bumps [@testing-library/dom](https://github.com/testing-library/dom-testing-library) from 9.2.0 to 9.3.1. - [Release notes](https://github.com/testing-library/dom-testing-library/releases) - [Changelog](https://github.com/testing-library/dom-testing-library/blob/main/CHANGELOG.md) - [Commits](testing-library/dom-testing-library@v9.2.0...v9.3.1) --- updated-dependencies: - dependency-name: "@testing-library/dom" dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
| @@ -39,9 +39,9 @@ | |||
| "devDependencies": { | |||
| "@next/bundle-analyzer": "^13.4.9", | |||
| "@next/eslint-plugin-next": "^13.4.9", | |||
| "@testing-library/dom": "^9.2.0", | |||
| "@testing-library/dom": "^9.3.1", | |||
There was a problem hiding this comment.
I wonder if we should remove @testing-library/dom from devDependencies, since @testing-library/react pulls it in as a dependency.
There was a problem hiding this comment.
From Next discussion boards:
The short answer is: it doesn't matter, unless you are only installing dependencies (with npm/yarn install --production). For consistency, I add all build/dev/test tools in devDependencies, and the rest of the stuff in dependencies.
The situation where you might face problems is when you are only installing the dependencies and not devDependencies. Keep in mind Next.js will run your code both in the client and the server, so if you have a server-rendered page, and the app does not have less listed in the dependencies list, then your server will crash when trying to render the page.
Combine these dependabot PRs, to get the tests passing.