Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MPP-3487: Update to Python 3.12 #5180

Merged
merged 3 commits into from
Nov 13, 2024
Merged

MPP-3487: Update to Python 3.12 #5180

merged 3 commits into from
Nov 13, 2024

Conversation

jwhitlock
Copy link
Member

Update to use Python 3.12 everywhere. Fixes #3982.

google-cloud-sqlcommenter does not work with Python 3.12 and later. The code was donated to OpenTelemetry, but has not been integrated into the Python SDK, and no further releases have been made.

Production is using Postgres 14.13, so this updates that as well.

How to test:

@jwhitlock jwhitlock marked this pull request as draft November 8, 2024 16:54
@jwhitlock
Copy link
Member Author

Migrations tests will fail until https://github.com/mozilla/fx-private-relay/releases/tag/2024.11.07 is in production with #5167. This can wait until next week or later.

This package does not work with Python 3.12. The code was donated to
OpenTelemetry, but they have not integrated it into their codebase.
@jwhitlock jwhitlock marked this pull request as ready for review November 12, 2024 23:02
@jwhitlock
Copy link
Member Author

2024.11.07 is in production, and handled the morning emails as normal, so I'm marking this as ready.

Copy link
Member

@groovecoder groovecoder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice. Good call on removing sqlcommenter too. One less dependency and we haven't used it lately.

@groovecoder groovecoder added this pull request to the merge queue Nov 13, 2024
Merged via the queue into main with commit aebe2bf Nov 13, 2024
30 checks passed
@groovecoder groovecoder deleted the python-312-mpp-3487 branch November 13, 2024 20:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upgrade to Python 3.12
2 participants