This repository has been archived by the owner on Apr 3, 2019. It is now read-only.
feat(db): make database fault tolerant of db server #1716
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seanmonstar
force-pushed
the
db-tolerant
branch
2 times, most recently
from
d43c94b to
63ede1e
Compare
|
/cc @vladikoff @jrgm who mentioned this problem recently |
seanmonstar
commented
Mar 15, 2017
| // TODO: transition to api version | ||
| // patchLevel is mysql specific | ||
| if ( | ||
| api.patchLevel < options.patchLevel || |
There was a problem hiding this comment.
So, the returned api JSON didn't included a patchLevel, and our options don't have a patchLevel, so this becomes undefined < undefined, which is always false. So this never would throw an error, and currently could only give us a false sense of security. Killed.
There was a problem hiding this comment.
Ah good find, I think this works properly in db-mysql itself though 👍
seanmonstar
force-pushed
the
db-tolerant
branch
from
63ede1e to
f6c7806
Compare
|
I actually think this just an improvement all around. r? @vladikoff or @jrgm |
|
Restarting Circle build... |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is support of our docker-dev work in vladikoff/fxa-docker-dev#7. And it's currently WIP.
The idea here is that the auth-server should be able to stand up even if the db-server is currently on fire. We don't actually need to start listening for requests. If an incoming request needs access to the database, we will already correctly send back a 500 if the db connection fails.