Merge pull request #13907 from mozilla/fxa-5658-wrong-upgrade-emails

fix(subscriptions): wrong upgrade emails
mozilla · Aug 9, 2022 · d84af5e · d84af5e
2 parents 8d1f668 + 2b04aac
commit d84af5e
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 5 deletions.
diff --git a/packages/fxa-auth-server/lib/payments/stripe.ts b/packages/fxa-auth-server/lib/payments/stripe.ts
@@ -2898,7 +2898,7 @@ export class StripeHelper extends StripeHelperBase {
     } = this.mergeMetadata(planOld, abbrevProductOld);
 
     const updateType =
-      productOrderNew > productOrderOld
+      parseInt(productOrderNew) > parseInt(productOrderOld)
         ? SUBSCRIPTION_UPDATE_TYPES.UPGRADE
         : SUBSCRIPTION_UPDATE_TYPES.DOWNGRADE;
 

diff --git a/...-auth-server/test/local/payments/fixtures/stripe/event_customer_subscription_updated.json b/...-auth-server/test/local/payments/fixtures/stripe/event_customer_subscription_updated.json
@@ -51,7 +51,7 @@
               "interval_count": 1,
               "livemode": false,
               "metadata": {
-                "productOrder": 0,
+                "productOrder": "0",
                 "emailIconURL": "http://example.com/icon-new",
                 "successActionButtonURL": "http://example.com/download-new"
               },
@@ -93,7 +93,7 @@
         "interval_count": 1,
         "livemode": false,
         "metadata": {
-          "productOrder": 0,
+          "productOrder": "0",
           "emailIconURL": "http://example.com/icon-new",
           "successActionButtonURL": "http://example.com/download-new"
         },
@@ -121,7 +121,7 @@
         "interval": "month",
         "interval_count": 1,
         "metadata": {
-          "productOrder": 1,
+          "productOrder": "1",
           "emailIconURL": "http://example.com/icon-old",
           "successActionButtonURL": "http://example.com/download-old"
         },

diff --git a/packages/fxa-auth-server/test/local/payments/stripe.js b/packages/fxa-auth-server/test/local/payments/stripe.js
@@ -5163,7 +5163,7 @@ describe('StripeHelper', () => {
             .successActionButtonURL,
         'product:termsOfServiceURL': termsOfServiceURL,
         'product:privacyNoticeURL': privacyNoticeURL,
-        productOrder: 0,
+        productOrder: '0',
       },
     };