Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Coupons: Do not allow coupons that don't make sense to be applied. #12015

Closed
data-sync-user opened this issue Feb 23, 2022 · 5 comments · Fixed by #12512
Closed

Coupons: Do not allow coupons that don't make sense to be applied. #12015

data-sync-user opened this issue Feb 23, 2022 · 5 comments · Fixed by #12512
Labels
qa+ Critical flow or high chance of regression. QA should focus on testing this issue.

Comments

@data-sync-user
Copy link
Collaborator

data-sync-user commented Feb 23, 2022 •
edited
Loading

Issue:

The coupon discount applies to the billing period of the subscription. Currently we have monthly, every six months and yearly periods. However when we create a coupon we have the ability to make monthly repeating coupons. This means that if you have a 3 month repeating coupon and you use it subscribe to a product on 1/1/22 every billing period up until 4/1/22 will be discounted. However if you have a 6 month subscription only your first billing period will be discounted. This can be construed by our customers in a negative manor leaving them confused.

Solution:

For repeating coupons, ensure that the subscription length is < monthly otherwise return an error “This coupon cannot be used for this subscription”

[~accountid:60acc5180c6f2d0068633c71] any issues with the wording here.

┆Issue is synchronized with this Jira Task
┆Attachments: image-20220415-165528.png | Screenshot 2022-05-02 172829.png
@data-sync-user
Copy link
Collaborator Author

➤ Chris Rooney commented:

Works for me

This comment was left via Slack.

@data-sync-user
Copy link
Collaborator Author

➤ Bianca Danforth commented:

We would probably also want to update our Coupons docs to this effect.

StaberindeZA added a commit that referenced this issue Apr 15, 2022
@StaberindeZA
feat(coupons): do not allow coupons no sense
3b70259 
Because:

* Currently monthly repeating coupons can be used even though they could
  be applied to only part of the plan interval. (eg. Coupon duration of
  3 months, applied to a 6 month plan.) This leads to possible confusion
  for the customer, and should not be allowed.

This commit:

* Checks if the coupon duration will apply to the entire interval for
  a given plan.

Closes #12015
@StaberindeZA StaberindeZA mentioned this issue Apr 15, 2022
Merged
4 tasks
StaberindeZA added a commit that referenced this issue Apr 15, 2022
@StaberindeZA
feat(coupons): check coupons apply entire plan interval
a939611 
Because:

* Currently monthly repeating coupons can be used even though they could
  be applied to only part of the plan interval. (eg. Coupon duration of
  3 months, applied to a 6 month plan.) This leads to possible confusion
  for the customer, and should not be allowed.

This commit:

* Checks if the coupon duration will apply to the entire interval for
  a given plan.

Closes #12015
@data-sync-user
Copy link
Collaborator Author

➤ Reino Muhl commented:

Anna Sobiepanek could we reuse the generic error message “The code you entered is invalid” or do we want a new error message for this?

!image-20220415-165528.png|width=312,height=256!

StaberindeZA added a commit that referenced this issue Apr 15, 2022
@StaberindeZA
feat(coupons): check coupons apply entire plan interval
99489a6 
Because:

* Currently monthly repeating coupons can be used even though they could
  be applied to only part of the plan interval. (eg. Coupon duration of
  3 months, applied to a 6 month plan.) This leads to possible confusion
  for the customer, and should not be allowed.

This commit:

* Checks if the coupon duration will apply to the entire interval for
  a given plan.

Closes #12015
@data-sync-user
Copy link
Collaborator Author

➤ Anna Sobiepanek commented:

Lets keep the generic message

StaberindeZA added a commit that referenced this issue Apr 20, 2022
@StaberindeZA
feat(coupons): check coupons apply entire plan interval
70f47f3 
Because:

* Currently monthly repeating coupons can be used even though they could
  be applied to only part of the plan interval. (eg. Coupon duration of
  3 months, applied to a 6 month plan.) This leads to possible confusion
  for the customer, and should not be allowed.

This commit:

* Checks if the coupon duration will apply to the entire interval for
  a given plan.

Closes #12015
@data-sync-user data-sync-user added the qa+ Critical flow or high chance of regression. QA should focus on testing this issue. label Apr 26, 2022
@data-sync-user
Copy link
Collaborator Author

➤ Maria Berlinger commented:

Hello Anna Sobiepanek ,
This is verified as fixed in Train 1.231.3. For the 6 or 12 months subscription a coupon with a 3 month duration cannot be applied.

Please let us know if there is anything else we need to check.
See the attached screenshot.

!Screenshot 2022-05-02 172829.png|width=1155,height=551!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
qa+ Critical flow or high chance of regression. QA should focus on testing this issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(coupons): check coupons apply entire plan interval mozilla/fxa
1 participant
@data-sync-user