Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ESLint config is invalid for fxa-settings package #12933

Closed
pdehaan opened this issue May 18, 2022 · 0 comments · Fixed by #12934
Closed

ESLint config is invalid for fxa-settings package #12933

pdehaan opened this issue May 18, 2022 · 0 comments · Fixed by #12934

Comments

@pdehaan
Copy link
Contributor

pdehaan commented May 18, 2022 •
edited by data-sync-user
Loading

Description

THe lint script points to an invalid lint:sass script which causes a build failure when trying to run yarn lint in packages/fxa-settings folder.

I have a pending PR for this, but figured I should file an issue which I can then say my PR closes.

Steps to reproduce

fxa/packages/fxa-settings/package.json

Lines 12 to 13 in 9cb8888

"lint:eslint": "eslint .",
"lint": "npm-run-all --parallel lint:eslint lint:sass",

Expected result

No errors

Actual result

errors

Environment

macOS.

┆Issue is synchronized with this Jira Task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore(lint): Fix linting in fxa-settings package mozilla/fxa
1 participant
@pdehaan