Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(lint): Fix linting in fxa-settings package #12934

Merged
merged 1 commit into from
May 20, 2022
Merged

Conversation

pdehaan
Copy link
Contributor

@pdehaan pdehaan commented May 18, 2022

Because

  • linting currently fails hard due to missing "lint:sass" script.

This pull request

  • removes reference to undefined "lint:sass" script
  • moves the ESLint config from the package.json into the more standard/consistent .eslintrc.json file
  • lints the hidden .storybook/ folder

Issue that this pull request solves

Closes: #12933

Checklist

Put an x in the boxes that apply

  • My commit is GPG signed.
  • If applicable, I have modified or added tests which pass locally.
  • I have added necessary documentation (if appropriate).
  • I have verified that my changes render correctly in RTL (if appropriate).

Screenshots (Optional)

Please attach the screenshots of the changes made in case of change in user interface.

Other information (Optional)

Any other information that is important to this pull request.

@pdehaan pdehaan requested a review from a team as a code owner May 18, 2022 18:25
@LZoog
Copy link
Contributor

LZoog commented May 20, 2022

Asked in Slack, but just in case someone else sees this and thinks to merge it, I've asked Peter to fix up his commit to match our guidelines 😎

@pdehaan pdehaan force-pushed the pdehaan/fxa-settings-lint branch 2 times, most recently from ddfca63 to 767ee7c Compare May 20, 2022 17:03
@pdehaan pdehaan force-pushed the pdehaan/fxa-settings-lint branch from 767ee7c to b7b5019 Compare May 20, 2022 17:06
@pdehaan pdehaan changed the title Fix linting in fxa-settings package chore(lint): Fix linting in fxa-settings package May 20, 2022
@LZoog LZoog merged commit 2d11cb4 into main May 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ESLint config is invalid for fxa-settings package
3 participants