fix(fxa-settings): align password CTA #12492
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because:
refresh buttons, the Password row CTA button seems out of alignment.
This commit:
UnitRow with buttons that have a refresh button.
Closes #11972
Checklist
Put an
x
in the boxes that applyScreenshots (Optional)
Before:
After:
RTL (before changes):
Other information (Optional)
Styles deliberately do not have the
rtl
prefix, as the position of the buttons does not change when the text direction of the page changes, as shown in the above screenshot. Has been tested in Arabic and Hebrew.Looking at the new button alignment, I think it might be worth leaving the designs as they originally were -- to my eye the buttons have a slight optical illusion of being misaligned (even when they do line up) due to the buttons above the Security section all lining up flatly with the right-hand side of their container. I would really appreciate eyes + opinions on it!