feat(scripts): use redlock to prevent >1 instance of paypal-processor #12610
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@bbangert Here's the auto-renewing lock approach. It feels cleaner since we get out of the business of running a timer and manually extending the lock. |
|
@chenba yep, agreed, this is a bit cleaner. |
Because: - we could easily end up running two instances of the paypal-processor during a deploy This commit: - use a redis based distributed lock to ensure only one paypal-processor can run per env - add script options to control the lock name and duration, as well as completely bypassing the lock
chenba
force-pushed
the
fxa-4698-paypal-lock-auto-extend
branch
from
0257267 to
8adcdc0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because:
during a deploy
This commit:
paypal-processor can run per env
completely bypassing the lock