Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Icons and urls #12618

Merged
merged 3 commits into from
Apr 22, 2022
Merged

Icons and urls #12618

merged 3 commits into from
Apr 22, 2022

Conversation

clouserw
Copy link
Member

Because

  • Some of our relying parties didn't have icons and links

This pull request

  • Adds icons and links

Issue that this pull request solves

Closes #12570 Closes #12571 Closes #12572
Closes FXA-4913 Closes FXA-4914 Closes FXA-4915

@clouserw clouserw requested a review from a team as a code owner April 21, 2022 16:00
dschom
dschom approved these changes Apr 21, 2022
View reviewed changes
Copy link
Contributor

@dschom dschom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! It would be nice address the falling test coverage stat if possible.

packages/fxa-settings/src/components/ConnectedServices/Service.tsx Show resolved Hide resolved
@clouserw
Copy link
Member Author

Test coverage:

--------------------------------------------|---------|----------|---------|---------|--------------------------------
File                                        | % Stmts | % Branch | % Funcs | % Lines | Uncovered Line #s              
--------------------------------------------|---------|----------|---------|---------|--------------------------------
 src/components/ConnectedServices           |   91.26 |    94.12 |      80 |   91.26 |                                
  Service.tsx                               |   97.14 |    95.45 |     100 |   97.14 | 76                             
  index.tsx                                 |   88.24 |     93.1 |   78.95 |   88.24 | 89,140,157,183-184,204,249-250

@clouserw clouserw merged commit 1f003a5 into main Apr 22, 2022
@clouserw clouserw deleted the icons-and-urls branch April 22, 2022 16:40
@data-sync-user data-sync-user mentioned this pull request May 19, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dschom dschom dschom approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@clouserw @dschom