Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(admin-server): Fix watch on schema.gql #12643

Merged
merged 1 commit into from
Apr 25, 2022
Merged

fix(admin-server): Fix watch on schema.gql #12643

merged 1 commit into from
Apr 25, 2022

Conversation

dschom
Copy link
Contributor

@dschom dschom commented Apr 25, 2022

Because

  • The schema.gql file wasn't updating properly.

This pull request

  • Updates the nestjs config so as to ensure the schema.gql file is copied to dist
  • Updates the nestjs config so as to ensure the schema.gql is auto updated after changes to models.

Issue that this pull request solves

Closes: #12642

Checklist

Put an x in the boxes that apply

  • My commit is GPG signed.
  • If applicable, I have modified or added tests which pass locally.
  • I have added necessary documentation (if appropriate).
  • I have verified that my changes render correctly in RTL (if appropriate).

@dschom dschom requested a review from a team as a code owner April 25, 2022 21:19
@dschom
fix(admin-server): Fix watch on schema.gql
1c3d220 
Because:
- The schema.gql file wasn't updating properly.

This Commit:
- Updates the nestjs config so as to ensure the schema.gql file is copied to dist
- Updates the nestjs config so as to ensure the schema.gql is auto updated after changes to models.
@dschom dschom force-pushed the graphql-schema-gen-fix branch from 616bbd8 to 1c3d220 Compare April 25, 2022 21:19
millmason
millmason approved these changes Apr 25, 2022
View reviewed changes
Copy link
Contributor

@millmason millmason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks perfect 👍

LZoog
LZoog approved these changes Apr 25, 2022
View reviewed changes
Copy link
Contributor

@LZoog LZoog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yaaas thanks

@dschom dschom merged commit 5c2b672 into main Apr 25, 2022
@dschom dschom deleted the graphql-schema-gen-fix branch August 1, 2022 22:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LZoog LZoog LZoog approved these changes

@millmason millmason millmason approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

schema.gql not updating after model change
3 participants
@dschom @millmason @LZoog