Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(content-server): Fix issue on login with legacy accounts #12663

Merged
merged 1 commit into from
Apr 26, 2022
Merged

fix(content-server): Fix issue on login with legacy accounts #12663

merged 1 commit into from
Apr 26, 2022

Conversation

dschom
Copy link
Contributor

@dschom dschom commented Apr 26, 2022

Because

  • There was a regression in the last maintenance sprint when removing the ecosystemAnonId.

This pull request

  • Adds a collection of ​​DEPRECATED_KEYS that represent keys which may exist on legacy account data and need to be gracefully removed.
  • Adds a test to make sure that a known deprecated field is handled and does not result in an error state.
  • Adds a test to make sure that errors are still thrown for invalid keys.

Issue that this pull request solves

Closes: #12630

Checklist

Put an x in the boxes that apply

  • My commit is GPG signed.
  • If applicable, I have modified or added tests which pass locally.
  • I have added necessary documentation (if appropriate).
  • I have verified that my changes render correctly in RTL (if appropriate).

@dschom dschom requested a review from a team as a code owner April 26, 2022 21:36
@dschom
fix(content-server): Fix issue on login with legacy accounts
b301bc1 
Because:
- There was a regression in the last maintenance sprint when removing the ecosystemAnonId.

This Commit:
- Adds a collection of ​​DEPRECATED_KEYS that represent keys which may exist on legacy account data and need to be gracefully removed.
- Adds a test to make sure that a known deprecated field is handled and does not result in an error state.
- Adds a test to make sure that errors are still thrown for invalid keys.
LZoog
LZoog approved these changes Apr 26, 2022
View reviewed changes
Copy link
Contributor

@LZoog LZoog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Yeah this is right along the lines on what I thought we'd need to do. Thanks for the fix!

@dschom dschom merged commit c3e1209 into main Apr 26, 2022
@dschom dschom deleted the FXA-4954 branch August 1, 2022 22:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LZoog LZoog LZoog approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ecosystemAnonId cannot be set on an Account
2 participants
@dschom @LZoog