Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 1.231.0 #12679

Merged
merged 12 commits into from
May 4, 2022
Merged

Release 1.231.0 #12679

merged 12 commits into from
May 4, 2022

Conversation

annasob
Copy link
Contributor

@annasob annasob commented Apr 27, 2022

🚆

@annasob annasob requested a review from a team as a code owner April 27, 2022 17:40
Copy link
Contributor

@LZoog LZoog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🎉

If we end up needing another dot release for 231 to make it to staging successfully, you can either merge this PR and then open another PR for the train -> main again, or just leave this open and preferably dismiss my review so someone can review the next dot release. Fingers crossed we don't need that.

Copy link
Contributor

@LZoog LZoog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with .2 + .3, merge wheneva🎉

@fxa-deployment-status fxa-deployment-status bot temporarily deployed to staging May 2, 2022 15:36 Inactive
bbangert and others added 3 commits May 2, 2022 09:51
Because:

* A refactor accidentally changed the collection name.

This commit:

* Restores the collection name without the duplicate prefix.

Closes #12727
fix(auth): fix collection prefix for iap
@bbangert bbangert merged commit a744158 into main May 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants