Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(fxa-content-server): add spacing bn 3rd party auth buttons #12700

Merged
merged 1 commit into from
May 4, 2022
Merged

fix(fxa-content-server): add spacing bn 3rd party auth buttons #12700

merged 1 commit into from
May 4, 2022

Conversation

millmason
Copy link
Contributor

@millmason millmason commented Apr 28, 2022 •
edited
Loading

Because:

This commit/pull request:

  • Raises the "margin-bottom" style on ".third-party-auth .login-button"
    from 5px to 10px

Closes #11281

Checklist

Put an x in the boxes that apply

  • My commit is GPG signed.
  • If applicable, I have modified or added tests which pass locally.
  • I have added necessary documentation (if appropriate).
  • I have verified that my changes render correctly in RTL (if appropriate).

Screenshots (Optional)

Before (desktop):
Screen Shot 2022-04-28 at 12 48 40 PM

Before (mobile):
Screen Shot 2022-05-02 at 2 20 51 PM

After (desktop):
Screen Shot 2022-04-28 at 12 48 26 PM

After (mobile):
Screen Shot 2022-05-02 at 2 21 17 PM

@millmason
fix(fxa-content-server): add spacing bn 3rd party auth buttons
02e1a31 
Because:

* Github issue #12281 asks for "at least 4 pixels" more spacing between
  third party auth buttons

This commit:

* Raises the "margin-bottom" style on ".third-party-auth .login-button"
  from 5px to 10px

Closes #11281
@millmason millmason requested a review from a team as a code owner April 28, 2022 19:55
vbudhram
vbudhram approved these changes May 4, 2022
View reviewed changes
Copy link
Contributor

@vbudhram vbudhram left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@millsoper 🕵🏽

@millmason millmason merged commit 16a1e6e into main May 4, 2022
@millmason millmason deleted the fxa-4774-space-3rd-party-login-buttons branch May 4, 2022 18:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vbudhram vbudhram vbudhram approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@millmason @vbudhram