Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(mjml): Use minifyOptions instead of minify for mjml templates #12738

Merged
merged 1 commit into from
May 3, 2022

Conversation

vbudhram
Copy link
Contributor

@vbudhram vbudhram commented May 2, 2022

Because

  • Auth-server output gets noisey with mjml warnings

This pull request

  • Updates the render to specify options for mjml

Issue that this pull request solves

Closes: #12737

Checklist

  • My commit is GPG signed.
  • If applicable, I have modified or added tests which pass locally.
  • I have added necessary documentation (if appropriate).
  • I have verified that my changes render correctly in RTL (if appropriate).

Other information

@xlisachan @LZoog You mind taking a look at this when you get a moment? I believe these are the right configs for mjml render but I am not super familiar with it.

@vbudhram vbudhram requested a review from a team as a code owner May 2, 2022 21:06
@vbudhram vbudhram requested review from LZoog and xlisachan May 2, 2022 21:06
Copy link
Contributor

@xlisachan xlisachan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yay! 🎉

I only remember the warning would come up when I ran yarn test test/local/senders/emails.ts in fxa-auth-server, so I pulled your branch, ran the test, and the warning is gone!! If there is another place to check, please let me know. 👀

Thanks for fixing this, Vijay!

@vbudhram vbudhram merged commit 8bfff6a into main May 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"minify" option is deprecated in mjml-core and only available in mjml cli
2 participants