fix(fxa-admin-panel) temporarily add logging to debug on staging #12749
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
millmason
force-pushed
the
testing-headers-for-stage
branch
2 times, most recently
from
7b88171 to
a9f86cd
Compare
dschom
reviewed
May 3, 2022
| @@ -126,6 +127,7 @@ export const AccountSearch = () => { | |||
|
|
|||
| const handleSubmit = (event: React.FormEvent) => { | |||
| event.preventDefault(); | |||
| const trimmedSearchValue = searchInput.trim(); | |||
There was a problem hiding this comment.
Is this from a previous PR or bad merge? Seems trimmedSearchValue is unused?
There was a problem hiding this comment.
Yeah it was -- removed now!
| } | ||
|
|
||
| logger.info('userGroupHeader', { 'userGroupHeader.null': userGroupHeader }); | ||
| logger.info('headers', { headers }); |
There was a problem hiding this comment.
This is kinda weird, but these end up as cols in the logs db. Can we just do something like msg: JSON.stringify(headers)? Since this is just a temporary log probably better to just log out a message.
There was a problem hiding this comment.
Let's just keep these all these as logger.info('userGroupHeader', {...}) It'll make searching for the logs simpler.
|
|
||
| @Injectable() | ||
| export class UserGroupGuard implements CanActivate { | ||
| constructor(private reflector?: Reflector) {} | ||
| constructor(private reflector?: Reflector, private log?: MozLoggerService) {} |
millmason
force-pushed
the
testing-headers-for-stage
branch
from
a9f86cd to
0ad1c74
Compare
This was referenced May 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because
This pull request
Issue that this pull request solves
Closes: # n/a
Checklist
Put an
xin the boxes that apply