task(settings): Disable 2FA and Recovery Code actions when account has no password #12819
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s no password Because: - With third party oauth, we might enter into a state where the user has authenticated, but has not supplied a password yet. In this case, setting up recovery codes or 2FA isn’t applicable. This Commit: - Introduces hasPassword flag on account model - Guards routes associated to 2FA and recovery codes in the event the account does not have a password - Disables 2FA and recovery code action buttons in the event a user’s account has no password set. - Provides a tooltip hint on the disabled action button that a password must be set in order to use certain features or sync.
dschom
force-pushed
the
FXA-5043-require-passwords-for-rc-and-2fa
branch
from
00bba1d to
6c911c6
Compare
LZoog
reviewed
May 10, 2022
packages/fxa-settings/src/components/UnitRowRecoveryKey/index.tsx
Outdated
Show resolved
Hide resolved
|
@LZoog Thanks for the review. I've addressed the feedback. Concerns about mobile can be addressed in another ticket. IMO, they are not that serious. |
LZoog
approved these changes
May 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because
This pull request
Issue that this pull request solves
Closes: #12774
Checklist
Put an
xin the boxes that applyScreenshots (Optional)
Other Information
To test this state, login with a third party oauth account (apple or google) for the first time. This will result in a state where you have been authenticated, but haven't set a password yet.