Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(fxa-admin-panel) use clearer icons to indicate permission status #12826

Merged
merged 1 commit into from
May 18, 2022

Conversation

millmason
Copy link
Contributor

@millmason millmason commented May 10, 2022

Because

  • Currently, a user can be confused as to whether they have a given permission or not, because the negative symbol is x. We use clearer positive/negative symbols to indicate permission status.

This pull request

  • Replaces the symbols with more vivid unicode symbols (U+2705: ✅ and U-274C: ❌)

Issue that this pull request solves

Closes: #12743

Checklist

Put an x in the boxes that apply

  • My commit is GPG signed.
  • If applicable, I have modified or added tests which pass locally.
  • I have added necessary documentation (if appropriate).
  • I have verified that my changes render correctly in RTL (if appropriate).

Screenshots (Optional)

Before (user has permissions):
Screen Shot 2022-05-10 at 10 19 33 AM

Before (user does not have permissions):
Screen Shot 2022-05-10 at 10 18 42 AM

After (user has permissions):
Screen Shot 2022-05-10 at 10 19 42 AM

After (user does not have permissions):
Screen Shot 2022-05-10 at 10 18 55 AM

To test:
With the fxa-admin-panel app running in local, visit http://localhost:8091/permissions and observe the permissions for your user. I don't know how to change the permissions for the logged in user, but to view the opposite of whatever permissions you're seeing, switch the values in the ternary here like so: val: flag.enabled ? '❌' : '✅',

@millmason millmason force-pushed the fxa-5026-clearer-permissions branch from 2975b57 to 39fa127 Compare May 10, 2022 17:34
@millmason millmason marked this pull request as ready for review May 10, 2022 17:43
@millmason millmason requested a review from a team as a code owner May 10, 2022 17:43
@millmason millmason merged commit 161c9fc into main May 18, 2022
@millmason millmason deleted the fxa-5026-clearer-permissions branch May 18, 2022 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make admin permissions more clear
2 participants