chore(payments): Missing markup in payment-confirm string #12875
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
packages/fxa-payments-server/src/components/PaymentConsentCheckbox/index.test.tsx
Outdated
Show resolved
Hide resolved
StaberindeZA
approved these changes
May 17, 2022
There was a problem hiding this comment.
r+ wc.
@sardesam There's some small changes on the tests I was hoping you could make, but otherwise looks good.
packages/fxa-payments-server/src/components/PaymentConsentCheckbox/index.test.tsx
Outdated
Show resolved
Hide resolved
| expect( | ||
| legalCheckbox.props.children.props.children[1].props.children | ||
| ).toMatch( | ||
| /\$\d+[.]\d{2}[ ][daily|every 6 days|weekly|every 6 weeks|monthly|every 6 months|yearly|every 6 years]/ |
There was a problem hiding this comment.
This would work, however it runs the risk of returning a false positive. (If for some reason, as a bug, formatPlanPricing returns "daily" regardless of input, all these tests will still pass, even though there's a bug)
This shouldn't hold up the change though, so feel free to squash and merge.
StaberindeZA
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because
This pull request
Issue that this pull request solves
Closes: #12726
Checklist
Put an
xin the boxes that applyScreenshots (Optional)
Please attach the screenshots of the changes made in case of change in user interface.
Other information (Optional)
Any other information that is important to this pull request.