-
Notifications
You must be signed in to change notification settings - Fork 212
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(admin-panel): Add information pertaining to bounceType #12877
Conversation
We use
|
580aedd
to
337de9b
Compare
337de9b
to
9c8dce5
Compare
@xlisachan The dedent library just smartly strips leading white space on newlines, but it doesn't actually add any html, which is why you aren’t seeing any effect. There are two ways I can think of dealing with this. One approach could be using wrapping the text with pre block and applying the appropriate styling. Another option, that I think would be better, is to return jsx with html tags to render the output as desired from the bounce-descritions.tsx. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Aside from the dedent issue, which isn't that big a deal imo, this looks good to me.
765d443
to
cc4206e
Compare
Thanks for the feedback, @dschom ! I have made the following updates:
Can you please review this PR again when you have a moment? Thank you! |
Because: * it would provide more information when clearing email bounces This commit: * adds descriptions for bounce type/subtype based on Amazon SES Closes #12155
cc4206e
to
b465f92
Compare
Because:
This commit:
Undetermined
toBounceType
, andOnAccountSuppressedList
toBounceSubType
ResultListItem
toResultTableRow
verified
/not verified
style as they were not appearing green/redCloses #12155
Questions:
dedent
is not applying multi-line strings o_O - removeddedent
BounceType
? -Undetermined
- added toBounceType
BounceSubType
? -OnAccountSuppressionList
- added toBounceSubType
Checklist
Put an
x
in the boxes that applyScreenshots (Optional)
BEFORE
AFTER
Connected Services