-
Notifications
You must be signed in to change notification settings - Fork 212
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(deps): Upgrade hapi/joi dependency #12885
Conversation
5a02709
to
3b15b34
Compare
0d0706b
to
ed68aee
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Just remove that one unneeded async statement and it is good to go.
0bf2a92
to
a7a73d9
Compare
Please note, the first commit ( The second commit (
Also, I tried upgrading to joi v17.6.0 (the latest version) again, but Thanks! :) |
@dschom, please let me know if you have any additional feedback or whether it's good to merge as I don't believe you can mark this PR as approved again after your initial review. Thanks! :) |
(Dan said it's gtg, rebasing and merging! \o/) |
Initial review - #12578
Because
This pull request
celebrate
uses joi 17.4.0.)error !== null
as "whenfxa-payments-server
gets an error from the backend, it throws an APIError"Issue that this pull request solves
Closes: #12178
Closes: #12477
Closes: #12528
Put an
x
in the boxes that applyFollow-up tickets
- Investigate
typesafe-joi
dependency and better solution as it is a fork of hapi/joi v15.x