feat(payments): rename downloadURL to successActionButtonURL #12904
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
StaberindeZA
force-pushed
the
fxa-3611-rename-downloadurl
branch
from
c6fa9c2 to
bdbc5bf
Compare
StaberindeZA
changed the title
Because: * The button on the success screen allows for a configurable label, which means it can be used for more than just downloading the product, which makes the configuration field "downloadURL" misleading. This commit: * Adds support for a new configuration field "successActionButtonURL" to replace "downloadURL". * Updates the code to reflect the name change. Closes #9338
StaberindeZA
force-pushed
the
fxa-3611-rename-downloadurl
branch
from
bdbc5bf to
e784754
Compare
chenba
reviewed
May 25, 2022
| @@ -2354,9 +2354,13 @@ export class StripeHelper extends StripeHelperBase { | |||
| const productMetadata = this.mergeMetadata(plan, abbrevProduct); | |||
| const { | |||
| emailIconURL: planEmailIconURL = '', | |||
| downloadURL: planDownloadURL = '', | |||
| downloadURL, | |||
There was a problem hiding this comment.
Why is this still here since we are replacing the "download" url in this patch?
There was a problem hiding this comment.
Ok, I see a TODO below that's likely the reason for this. Is there a jira file to remove this?
There was a problem hiding this comment.
Ah yes that's what I forgot. There is one now, thank you.
chenba
reviewed
May 25, 2022
chenba
reviewed
May 25, 2022
chenba
reviewed
May 25, 2022
| @@ -67,7 +67,8 @@ class SetPassword extends FormView { | |||
| const plan = plans.find((p) => p.product_id === productId); | |||
| const url = new URL( | |||
| plan && plan.product_metadata | |||
| ? plan.product_metadata.downloadURL | |||
| ? plan.product_metadata.successActionButtonURL || | |||
| plan.product_metadata.downloadURL | |||
| : 'https://mozilla.org' | |||
There was a problem hiding this comment.
I'm surprised that prettier didn't wrap some parens around this.
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because
which means it can be used for more than just downloading the product,
which makes the configuration field "downloadURL" misleading.
This pull request
replace "downloadURL".
Issue that this pull request solves
Closes: #9338
Checklist
Put an
xin the boxes that applyAdditional Info
successActionButtonURLto all products in Stripe Dev and Staging