Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(strings): Add default string for delete account checkbox #12913

Merged
merged 1 commit into from
May 17, 2022
Merged

Conversation

vbudhram
Copy link
Contributor

Because

  • These were not being translated

This pull request

  • Adds defaults for the checkboxes

Issue that this pull request solves

Closes: #12900

Checklist

  • My commit is GPG signed.
  • If applicable, I have modified or added tests which pass locally.
  • I have added necessary documentation (if appropriate).
  • I have verified that my changes render correctly in RTL (if appropriate).

Screenshots (Optional)

Screen Shot 2022-05-17 at 3 09 03 PM

Other information (Optional)

This will need to be uplifted to train 232, cc @chenba

@vbudhram vbudhram requested a review from a team as a code owner May 17, 2022 19:12
@vbudhram vbudhram self-assigned this May 17, 2022
@vbudhram vbudhram merged commit 1ce8b88 into main May 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FxA-Settings] Checkboxes text renders as "delete-account-chk-box-" in Delete account page
2 participants