-
Notifications
You must be signed in to change notification settings - Fork 212
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
style(auth): add space to alt text and underline #12956
Conversation
@@ -47,6 +47,10 @@ | |||
padding: global.$s-5 global.$s-0 !important; | |||
height: 56px !important; | |||
display: block !important; | |||
|
|||
a { | |||
font-size: 13px !important; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it possible to @extend .text-xs
or @extend .text-sm
here instead? Not sure where 13px
is coming from (as recommended in the ticket) since nothing else in our emails should use that font-size 🤔
If we have to use 13px
here, I'd leave a comment above it noting it's kind of a hack since it breaks our font-size conventions.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agreed. I will update to apply directly to the parent class to target both the <a>
and (override the default) <img>
tags using our font-size conventions.
The 13px font-size stemmed from earlier discussions in the mjml repo: #472 and #577. 13px was then added as the default img font-size for mj-image. However, it only applies to <img>
(that is, it was intended for the alt tag) and not a wrapping <a>
tag.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
If you'd like, you could leave a comment above your change noting why we need that on an img
, I'd hope someone might look at the commit history and find the issue associated before removing a line of code like that but it can be nice to have there to make sure since it does seem odd to need it. Not a must though.
Because: * We want to maintain consistent design, UX and a11y in emails This commit: * Adds font-size to create whitespace between text and underline Closes #12600
Comment added and also changed the declaration to target |
Because
This pull request
Issue that this pull request solves
Closes: #12600
Checklist
Put an
x
in the boxes that applyScreenshots (Optional)
N/A
Other information (Optional)
N/A