Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(fxa-shared): add missing type declarations for AppendedAppStore/P… #12967

Merged
merged 1 commit into from
May 20, 2022
Merged

fix(fxa-shared): add missing type declarations for AppendedAppStore/P… #12967

merged 1 commit into from
May 20, 2022

Conversation

biancadanforth
Copy link
Contributor

@biancadanforth biancadanforth commented May 20, 2022 •
edited
Loading

…layStoreSubscriptionPurchase

TS error introduced by PR #12890. #12823 will fix these types of errors permanently.

Closes: # No issue

Checklist

Put an x in the boxes that apply

  • My commit is GPG signed.
  • If applicable, I have modified or added tests which pass locally.
  • I have added necessary documentation (if appropriate).
  • I have verified that my changes render correctly in RTL (if appropriate).

@biancadanforth
fix(fxa-shared): add missing type declarations for AppendedAppStore/P…
7f64804 
…layStoreSubscriptionPurchase

TS error introduced by PR#12890; #12823 will fix these types of errors permanently.
@biancadanforth biancadanforth requested a review from a team as a code owner May 20, 2022 15:44
vbudhram
vbudhram approved these changes May 20, 2022
View reviewed changes
Copy link
Contributor

@vbudhram vbudhram left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Our auth server script tests seem to be flaking out, gonna restart them.

@biancadanforth biancadanforth merged commit d42c81a into main May 20, 2022
@biancadanforth biancadanforth deleted the fix-ts-issue-from-pr-12890 branch May 20, 2022 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vbudhram vbudhram vbudhram approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@biancadanforth @vbudhram