Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(admin-panel): Fix slow autocomplete in account search #12981

Merged
merged 1 commit into from
May 23, 2022

Conversation

dschom
Copy link
Contributor

@dschom dschom commented May 21, 2022

Because

  • Auto complete during account search was very slow

This pull request

  • Uses the normalizedEmail column which is optimized for search.
  • Also fixes an unlikely but possible non-lowercased email query in accountByEmail.

Issue that this pull request solves

Closes: #12346

Checklist

Put an x in the boxes that apply

  • My commit is GPG signed.
  • If applicable, I have modified or added tests which pass locally.
  • I have added necessary documentation (if appropriate).
  • I have verified that my changes render correctly in RTL (if appropriate).

Because:
- Auto complete during account search was very slow

This Commit:
- Uses the normalizedEmail column which is optimized for search.
- Also fixes an unlikely but possible non-lowercased email query in accountByEmail.
@dschom dschom requested a review from millmason May 23, 2022 16:36
@dschom dschom marked this pull request as ready for review May 23, 2022 16:36
@dschom dschom requested a review from a team as a code owner May 23, 2022 16:36
@dschom dschom merged commit f042a9f into main May 23, 2022
@dschom dschom deleted the FXA-4791-slow-auto-complete-on-account-search branch August 1, 2022 22:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

admin account search is slow
2 participants