fix(admin-server): Fix broken build command #13017
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Because: - There were issues starting the admin-server. This Commit: - Introduces a dev.json to solve issues with missing dev settings. - Make sure the dist folder is actually cleaned. It was possible that a stale config.js file could cause problems. - Make sure build is run and config/*.json files are copied over.
dschom
force-pushed
the
fix-admin-server-ci-issue
branch
from
d1500e5 to
17e2f77
Compare
dschom
commented
May 24, 2022
| @@ -4,10 +4,10 @@ | |||
| "description": "FxA GraphQL Admin Server", | |||
| "scripts": { | |||
| "prebuild": "rimraf dist", | |||
| "build": "yarn nest build && cp ./src/config/*.json ./dist/config", | |||
| "build": "yarn prebuild && yarn nest build && cp ./src/config/*.json ./dist/config", | |||
There was a problem hiding this comment.
I thought prebuild should run when yarn build was executed, but it doesn't seem to be the case...
biancadanforth
approved these changes
May 24, 2022
There was a problem hiding this comment.
Thanks Dan; I can confirm that fxa-admin-server builds successfully with this patch checked out.
For posterity, the error can be seen at https://app.circleci.com/pipelines/github/mozilla/fxa/30574/workflows/dce7b0cf-e47f-4eb8-b902-2e340bd0c2eb/jobs/336521/artifacts in the artifacts/fxa-builder.log file.
This is a separate issue, but when I run npx yarn workspaces foreach --topological-dev --verbose run build (which is what I used to reproduce this locally), I also see that the fxa-admin-panel is failing to build. Do you see that as well?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because
This pull request
Checklist
Put an
xin the boxes that applyOther information (Optional)
Trying to address CI failure, and issues other developers had starting admin-server.