Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(auth): create Apple notification handler #13020

Merged
merged 2 commits into from
May 25, 2022
Merged

feat(auth): create Apple notification handler #13020

merged 2 commits into from
May 25, 2022

Conversation

biancadanforth
Copy link
Contributor

Because:

  • We want to update our users' subscription status when Apple sends notifications for App Store purchases.

This commit:

  • Adds a notification handler that expects the notifications to be sent to a URL from the App Store Server.

Closes #10397

Checklist

Put an x in the boxes that apply

  • My commit is GPG signed.
  • If applicable, I have modified or added tests which pass locally.
  • I have added necessary documentation (if appropriate).
  • I have verified that my changes render correctly in RTL (if appropriate).

@biancadanforth biancadanforth requested a review from bbangert May 25, 2022 12:43
@biancadanforth biancadanforth requested a review from a team as a code owner May 25, 2022 12:43
biancadanforth
biancadanforth commented May 25, 2022
View reviewed changes
Copy link
Contributor Author

@biancadanforth biancadanforth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some questions for you inline.

Also, yarn build in fxa-auth-server is throwing some TS errors unrelated to my changes in cron job scripts like the paypal-processor and subscription-reminders. Would you know why that is the case? I don't see any related library updates.

packages/fxa-auth-server/lib/routes/subscriptions/apple.ts Show resolved Hide resolved
packages/fxa-auth-server/lib/routes/subscriptions/apple.ts Show resolved Hide resolved
packages/fxa-auth-server/lib/routes/subscriptions/apple.ts Outdated Show resolved Hide resolved
packages/fxa-auth-server/package.json Show resolved Hide resolved
packages/fxa-auth-server/test/local/ip_profiling.js Outdated Show resolved Hide resolved
bbangert
bbangert reviewed May 25, 2022
View reviewed changes
Copy link
Member

@bbangert bbangert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! One update to push and I can merge.

@biancadanforth biancadanforth force-pushed the fxa-3979 branch 3 times, most recently from b0e6145 to 3435d3f Compare May 25, 2022 18:19
xlisachan and others added 2 commits May 25, 2022 14:26
@xlisachan
Revert " chore(deps): Upgrade hapi/joi dependency"
68a45c4
@biancadanforth
feat(auth): create Apple notification handler
8c2ec84 
Because:

* We want to update our users' subscription status when Apple sends notifications for App Store purchases.

This commit:

* Adds a notification handler that expects the notifications to be sent to a URL from the App Store Server.

Closes #10397
@biancadanforth biancadanforth merged commit 8259947 into main May 25, 2022
@biancadanforth biancadanforth deleted the fxa-3979 branch May 25, 2022 19:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bbangert bbangert bbangert approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Create apple notification handler
3 participants
@biancadanforth @bbangert @xlisachan