Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(a11y): add a11y to modal close button svg #13049

Merged
merged 1 commit into from
May 31, 2022
Merged

fix(a11y): add a11y to modal close button svg #13049

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion packages/fxa-payments-server/src/components/DialogMessage/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,12 @@ export const DialogMessage = ({
aria-label="Close modal"
onClick={onDismiss as () => void}
>
<CloseIcon role="img" className="close-icon" />
<CloseIcon
role="img"
className="close-icon"
aria-hidden="true"
focusable="false"
/>
</button>
</Localized>
)}
Expand Down
7 changes: 6 additions & 1 deletion packages/fxa-payments-server/src/routes/Subscriptions/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -262,7 +262,12 @@ export const Subscriptions = ({
aria-label="Close modal"
onClick={hideSuccessAlert}
>
<CloseIcon role="img" className="close-icon close-alert-bar" />
<CloseIcon
role="img"
className="close-icon close-alert-bar"
aria-hidden="true"
focusable="false"
/>
</span>
</Localized>
</AlertBar>
Expand Down