Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(package): Remove node/npm engines from fxa-content-server/package.json #13113

Merged
merged 1 commit into from
Jun 1, 2022
Merged

chore(package): Remove node/npm engines from fxa-content-server/package.json #13113

merged 1 commit into from
Jun 1, 2022

Conversation

pdehaan
Copy link
Contributor

@pdehaan pdehaan commented May 31, 2022

Because

  • We already have a root .nvmrc file, so having similar [but very outdated] information is confusing.

This pull request

Issue that this pull request solves

Closes: #12895

Checklist

Put an x in the boxes that apply

  • My commit is GPG signed.
  • If applicable, I have modified or added tests which pass locally.
  • I have added necessary documentation (if appropriate).
  • I have verified that my changes render correctly in RTL (if appropriate).

Screenshots (Optional)

Please attach the screenshots of the changes made in case of change in user interface.

Other information (Optional)

Any other information that is important to this pull request.

@pdehaan pdehaan requested a review from a team as a code owner May 31, 2022 23:51
chenba
chenba approved these changes Jun 1, 2022
View reviewed changes
Copy link
Contributor

@chenba chenba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚒

@pdehaan
Copy link
Contributor Author

pdehaan commented Jun 1, 2022

I don't have merge access to this repo, if somebody can hit that shiny green merge button for me. 🙏

@chenba chenba merged commit d4ce249 into main Jun 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chenba chenba chenba approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Curious "engines" in fxa-content-server package
2 participants
@pdehaan @chenba