Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(payments): update PaymentMethodHeader component to utilize Tailwind #13709

Merged
merged 2 commits into from
Jul 21, 2022
Merged

refactor(payments): update PaymentMethodHeader component to utilize Tailwind #13709

merged 2 commits into from
Jul 21, 2022

Conversation

xlisachan
Copy link
Contributor

@xlisachan xlisachan commented Jul 21, 2022 •
edited
Loading

Because

  • we are converting to Tailwind

This pull request

  • Replace all CSS/SCSS with Tailwind utility classes
  • Remove .css and .scss files
  • Rework Storybook files

Issue that this pull request solves

Closes: #13586

Checklist

Put an x in the boxes that apply

  • My commit is GPG signed.

Screenshots

Default
Screen Shot 2022-07-21 at 12 48 11 PM

With prefix
Screen Shot 2022-07-21 at 12 48 18 PM

@xlisachan xlisachan requested a review from a team as a code owner July 21, 2022 16:36
@fxa-bananafox
Copy link
Contributor

fxa-bananafox bot commented Jul 21, 2022

I got u xlisachan. 💯

@xlisachan xlisachan force-pushed the FXA-5519_PaymentMethodHeader branch from f5bf5f7 to 3621ad2 Compare July 21, 2022 16:43
@fxa-bananafox
Copy link
Contributor

fxa-bananafox bot commented Jul 21, 2022

I got u xlisachan. 💯

@StaberindeZA StaberindeZA self-assigned this Jul 21, 2022
StaberindeZA
StaberindeZA approved these changes Jul 21, 2022
View reviewed changes
Copy link
Contributor

@StaberindeZA StaberindeZA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r+. Wohoo, lets get the party started.

@xlisachan xlisachan merged commit cb6d0b6 into main Jul 21, 2022
@xlisachan xlisachan deleted the FXA-5519_PaymentMethodHeader branch July 21, 2022 17:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@StaberindeZA StaberindeZA StaberindeZA approved these changes

Assignees

@StaberindeZA StaberindeZA

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[subplat][tailwind] Component - PaymentMethodHeader - Conversion
2 participants
@xlisachan @StaberindeZA