task(auth): Clean up redis cache after token pruning. #13886
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dschom
force-pushed
the
FXA-5128-trim-excessive-session-tokens-follow-up
branch
from
0b57390 to
333735c
Compare
chenba
reviewed
Aug 8, 2022
chenba
reviewed
Aug 8, 2022
chenba
reviewed
Aug 8, 2022
chenba
reviewed
Aug 8, 2022
chenba
approved these changes
Aug 8, 2022
dschom
force-pushed
the
FXA-5128-trim-excessive-session-tokens-follow-up
branch
from
333735c to
3f9b6a4
Compare
pdehaan
reviewed
Aug 8, 2022
dschom
force-pushed
the
FXA-5128-trim-excessive-session-tokens-follow-up
branch
from
3f9b6a4 to
4bca7a1
Compare
Because: - Tokens could be orphaned by pruning operations. This Commit: - Adds step to to prune-tokens script to proactively remove session tokens in Redis that were just pruned from sql. - Updates the prune sproc so that the set of affected accounts is relayed back to the token pruner. - Drops the pruneInterval arg from the prune sproc since it was no longer used now that this happens out of process.
dschom
force-pushed
the
FXA-5128-trim-excessive-session-tokens-follow-up
branch
from
4bca7a1 to
6a4c636
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because
This pull request
Issue that this pull request solves
Closes: # (issue number)
Checklist
Put an
xin the boxes that applyOther information (Optional)
This is a follow up to this PR. There was some feedback that was overlooked. This follow up PR fixes potential pit falls with dumping all session tokens from Redis for impacted users.