FXA-5679-l-10-n-export-is-broken-fatal-error-unexpected-token-93-10 #13904
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pdehaan
reviewed
Aug 8, 2022
| let errorDetails = null; | ||
| if (err != null && err.details instanceof Map) { | ||
| errorDetails = err.details.get('body'); | ||
| } | ||
|
|
||
| if (errorDetails) { | ||
| const message = `${errorDetails}`; |
There was a problem hiding this comment.
Q: Is this used somewhere that I'm not seein'?
Ah, seems to be used on L119 below and is some stringified version of the errorDetails object.
chenba
approved these changes
Aug 9, 2022
Because: - The `npx grunt l10n-extract` was breaking due to optional chaining syntax present in sentry.js - The l10n-extract uses the acorn parser under the hood, which doesn't appear to like optional chaining syntax. This Commit: - Ensures there is no optional chaining syntax present in the sentry.js file.
dschom
force-pushed
the
FXA-5679-l-10-n-export-is-broken-fatal-error-unexpected-token-93-10
branch
from
e3d82b8 to
8b741d2
Compare
dschom
deleted the
FXA-5679-l-10-n-export-is-broken-fatal-error-unexpected-token-93-10
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because
npx grunt l10n-extractwas breaking due to optional chaining syntax present in sentry.jsThis pull request
Issue that this pull request solves
Closes: #13893
Checklist
Put an
xin the boxes that apply