copy(fxa-auth-server): update email copy verificationReminderFirst

[millmason]

Because

• We're updating language in emails

This pull request

• Updates email copy strings and their corresponding localization IDs

Issue that this pull request solves

Closes: # n/a

Checklist

Put an x in the boxes that apply

• My commit is GPG signed.
• If applicable, I have modified or added tests which pass locally.
• I have added necessary documentation (if appropriate).
• I have verified that my changes render correctly in RTL (if appropriate).

Screenshots (Optional)

[bcolsson]

confirm-email-2 contains a colon, but looking at the mock-up this appears to be the button text. Should the colon be removed?

Or is verificationReminderFirst-action-2 the button text? If so, I'm not quite sure about the context where this appears.

[millmason]

It's a bit of an odd pattern to me, too -- it looks like it's just a variable that gets assigned into confirm-email-plaintext-2 below. There seems to be a pattern (also visible in the verificationReminderSecond email, for example) where in the standard version of the email, you get button with the CTA (sans colon), and then in the plaintext version, you get the same CTA, but as text followed by a colon, followed by a link. Like this (seen in storybook):

[bcolsson]

Interesting, but if that's the case then wouldn't having Confirm email: being called into { confirm-email-2 }: then result in Confirm email:: ?

[millmason]

🤦 Yeah it totally would. I'm so sorry I missed that, updating now

[bcolsson]

Thanks! Looks good now 👍

[chenba]

@bcolsson does : mean the same thing in all languages when used this way?

[millmason]

Hm....I just did a search and this is the only reference to confirm-email-2 in the verificationReminderFirst directory. I'm not aware of a reason why we couldn't just include the : in the string (which could solve this issue)

[bcolsson]

@chenba
Great question, thanks for asking!
Typically, yes, although different languages may need to adjust the structure slightly. For example French might need to insert a non breaking space before the colon. Even if the meaning were different since the colon is part of the string (and thus can be changed when translated), localizers are able to adjust the string to work in their languages.
Also of note, that a similar string structure already exists out in the wild (e.g. verifyPrimary-action-plaintext) so we should be safe.

[chenba]

hmm I don't think I'm reading this correctly. The localiser can still use another symbol (and in a different location relative to confirm-email-2); they just can't break up confirm-email-2 or translate it differently. So I think we are ok here?

[chenba]

Thanks, Bryan. (Saw your response after I posted my above comment.)