Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(fxa-auth-server): switch out partial to make mjml and txt consistent #13948

Merged
merged 1 commit into from
Aug 15, 2022
Merged

fix(fxa-auth-server): switch out partial to make mjml and txt consistent #13948

merged 1 commit into from
Aug 15, 2022

Conversation

millmason
Copy link
Contributor

Because

  • I forgot to add this fix in before merging the last PR

This pull request

  • Matches up the MJML and TXT footers

Issue that this pull request solves

Closes: # (issue number)

Checklist

Put an x in the boxes that apply

  • My commit is GPG signed.
  • If applicable, I have modified or added tests which pass locally.
  • I have added necessary documentation (if appropriate).
  • I have verified that my changes render correctly in RTL (if appropriate).

Screenshots (Optional)

Please attach the screenshots of the changes made in case of change in user interface.
Screen Shot 2022-08-15 at 1 07 06 PM

@millmason millmason force-pushed the FXA-5439-verifyLogin-fix branch 2 times, most recently from 05c2895 to 9246730 Compare August 15, 2022 20:29
@millmason millmason marked this pull request as ready for review August 15, 2022 20:52
@millmason millmason requested a review from a team as a code owner August 15, 2022 20:52
@millmason millmason force-pushed the FXA-5439-verifyLogin-fix branch from 9246730 to 7a7ddce Compare August 15, 2022 21:05
xlisachan
xlisachan approved these changes Aug 15, 2022
View reviewed changes
Copy link
Contributor

@xlisachan xlisachan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks :)

@millmason millmason merged commit f1ad746 into main Aug 15, 2022
@millmason millmason deleted the FXA-5439-verifyLogin-fix branch August 25, 2022 17:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xlisachan xlisachan xlisachan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@millmason @xlisachan