Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(functional-tests): Fix SubPlat Playwright tests #15371

Merged
merged 1 commit into from
Jun 6, 2023
Merged

fix(functional-tests): Fix SubPlat Playwright tests #15371

merged 1 commit into from
Jun 6, 2023

Conversation

xlisachan
Copy link
Contributor

@xlisachan xlisachan commented May 24, 2023 •
edited by jira bot
Loading

Because

  • Playwright tests fail during prod deploy

This pull request

  • skips SubPlat functional tests in prod, as test plans are not yet available in prod
  • fixes flow metrics errors in Playwright tests

Issue that this pull request solves

Closes:

Checklist

Put an x in the boxes that apply

  • My commit is GPG signed.
  • If applicable, I have modified or added tests which pass locally.

@xlisachan xlisachan force-pushed the FXA-7452-playwright branch from 7d7d67d to 46c2842 Compare May 30, 2023 20:53
@xlisachan xlisachan marked this pull request as ready for review May 31, 2023 16:47
@xlisachan xlisachan requested a review from a team as a code owner May 31, 2023 16:47
@xlisachan xlisachan force-pushed the FXA-7452-playwright branch 2 times, most recently from e743929 to 3591d4e Compare June 2, 2023 16:02
@xlisachan xlisachan mentioned this pull request Jun 2, 2023
Closed
4 tasks
@xlisachan xlisachan changed the title fix(functional-tests): Fix flow metrics errors in Playwright tests fix(functional-tests): Fix SubPlat Playwright tests Jun 2, 2023
@xlisachan xlisachan force-pushed the FXA-7452-playwright branch from 3591d4e to 2a6c0e9 Compare June 5, 2023 16:53
StaberindeZA
StaberindeZA approved these changes Jun 6, 2023
View reviewed changes
Copy link
Contributor

@StaberindeZA StaberindeZA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r+

Just one small question, with an optional change if it makes sense.

packages/functional-tests/pages/settings/components/unitRow.ts Outdated Show resolved Hide resolved
@xlisachan xlisachan force-pushed the FXA-7452-playwright branch from 2a6c0e9 to 3ee112d Compare June 6, 2023 15:01
@xlisachan xlisachan force-pushed the FXA-7452-playwright branch from 3ee112d to 3e1e00b Compare June 6, 2023 15:01
@xlisachan xlisachan merged commit 22ed106 into main Jun 6, 2023
@xlisachan xlisachan deleted the FXA-7452-playwright branch June 6, 2023 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@biancadanforth biancadanforth biancadanforth left review comments

@StaberindeZA StaberindeZA StaberindeZA approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@xlisachan @StaberindeZA @biancadanforth