Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test(functional): rewrite oauth permissions tests #15415

Merged
merged 2 commits into from
Jun 7, 2023
Merged

test(functional): rewrite oauth permissions tests #15415

merged 2 commits into from
Jun 7, 2023

Conversation

ashrivastava-qa
Copy link
Contributor

@ashrivastava-qa ashrivastava-qa commented Jun 6, 2023 •
edited
Loading

Because

As part of the playwright test migration, the oauth permissions and oauth prompt none have been rewritten in this PR.

This pull request

contains the tests identified as 'Keep' in the analysis sheet for oauth permissions and oauth prompt none

Issue that this pull request solves

Closes: FXA-5917 FXA-5920

Checklist

Put an x in the boxes that apply

  • My commit is GPG signed.
  • If applicable, I have modified or added tests which pass locally.
  • I have added necessary documentation (if appropriate).
  • I have verified that my changes render correctly in RTL (if appropriate).

Screenshots (Optional)

Please attach the screenshots of the changes made in case of change in user interface.

Other information (Optional)

Any other information that is important to this pull request.

@ashrivastava-qa ashrivastava-qa marked this pull request as ready for review June 6, 2023 23:24
@ashrivastava-qa ashrivastava-qa requested a review from a team as a code owner June 6, 2023 23:24
pdehaan
pdehaan approved these changes Jun 7, 2023
View reviewed changes
Copy link
Contributor

@pdehaan pdehaan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
Comments were all just nits, so feel free to ignore if we want to land this ASAP (and we can tweak in the future).

packages/functional-tests/tests/oauth/oauthPermissions.spec.ts Outdated Show resolved Hide resolved
packages/functional-tests/tests/oauth/oauthPermissions.spec.ts Outdated Show resolved Hide resolved
packages/functional-tests/tests/oauth/oauthPermissions.spec.ts Outdated Show resolved Hide resolved
packages/functional-tests/tests/oauth/oauthPermissions.spec.ts Show resolved Hide resolved
packages/functional-tests/tests/oauth/oauthPermissions.spec.ts Outdated Show resolved Hide resolved
packages/functional-tests/tests/oauth/oauthPromptNone.spec.ts Outdated Show resolved Hide resolved
packages/functional-tests/tests/oauth/oauthPromptNone.spec.ts Outdated Show resolved Hide resolved
@ashrivastava-qa
Copy link
Contributor Author

Thanks @pdehaan I'll make the nit changes and merge it.

@ashrivastava-qa ashrivastava-qa merged commit c15a9ee into main Jun 7, 2023
@ashrivastava-qa ashrivastava-qa deleted the rewrite-oauth-tests branch June 7, 2023 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pdehaan pdehaan pdehaan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ashrivastava-qa @pdehaan