fix(ip): Set x-forwarded-for header from gql to auth-server #15422
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clouserw
reviewed
Jun 7, 2023
| // Set the x-forwarded-for header since the auth-server will use this | ||
| // to determine client geolocation | ||
| if (ctx.req?.ip) { | ||
| headers['x-forwarded-for'] = ctx.req?.ip; |
There was a problem hiding this comment.
Just to be explicit here, ctx.req.ip does not come from a user-agent, right? (Meaning there is no possibility of injecting something here)
There was a problem hiding this comment.
Good call out, this value is populated from Graphql request and not injected.
LZoog
approved these changes
Jun 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because
This pull request
x-forwarded-forheader to the cllient ip address, the auth-server uses this value to perform geo locationIssue that this pull request solves
Closes: https://mozilla-hub.atlassian.net/browse/FXA-6858
Checklist