Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(text): Don't display Step 1 of 2 when deleting account with no password set #15452

Merged
merged 1 commit into from
Jun 15, 2023

Conversation

vbudhram
Copy link
Contributor

Because

  • Showing Step 1 of 2 doesn't make sense if there is no step 2

This pull request

  • Don't display any subtitle text when deleting account with no password

Issue that this pull request solves

Closes: https://mozilla-hub.atlassian.net/browse/FXA-7373

Checklist

  • My commit is GPG signed.
  • If applicable, I have modified or added tests which pass locally.
  • I have added necessary documentation (if appropriate).
  • I have verified that my changes render correctly in RTL (if appropriate).

Other information (Optional)

I thought this made more sense to not show anything verses showing Step 1 of 1.

@vbudhram vbudhram requested a review from LZoog June 15, 2023 14:46
@vbudhram vbudhram self-assigned this Jun 15, 2023
@vbudhram vbudhram requested a review from a team as a code owner June 15, 2023 14:46
Copy link
Contributor

@LZoog LZoog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@@ -364,7 +364,7 @@ const conf = (module.exports = convict({
},
clientId: {
default:
'210899493109-u0erdakhegg6b572faenm3mn9hf4mdp8.apps.googleusercontent.com',
'218517873053-th4taguk9dvf03rrgk8sigon84oigf5l.apps.googleusercontent.com',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this!

@vbudhram vbudhram merged commit c967d03 into main Jun 15, 2023
@vbudhram vbudhram deleted the fxa-7373 branch June 15, 2023 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants