Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(auth): handle Empty String Tax Display Name #15461

Merged
merged 1 commit into from
Jun 20, 2023

Conversation

IvoJP
Copy link
Contributor

@IvoJP IvoJP commented Jun 20, 2023

Because:

  • stripe started returning an empty string for tax display name which causes our response validation to fail

This commit:

  • ORs an empty string with undefined so that undefined is returned when display name is an empty string

Closes #FXA-7811

Checklist

Put an x in the boxes that apply

  • My commit is GPG signed.
  • If applicable, I have modified or added tests which pass locally.
  • I have added necessary documentation (if appropriate).
  • I have verified that my changes render correctly in RTL (if appropriate).

Because:

* stripe started returning an empty string for tax display name which causes our response validation to fail

This commit:

* ORs an empty string with undefined so that undefined is returned when display name is an empty string

Closes #
@IvoJP IvoJP requested a review from a team as a code owner June 20, 2023 17:39
@IvoJP IvoJP merged commit 77d0951 into main Jun 20, 2023
@IvoJP IvoJP deleted the tax-name-handle-empty-string branch June 20, 2023 17:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants