Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(email-first): Remove email-first related experiment code #3387

Merged
merged 1 commit into from
Nov 18, 2019
Merged

chore(email-first): Remove email-first related experiment code #3387

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion packages/fxa-content-server/app/scripts/lib/experiment.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,6 @@ const STARTUP_EXPERIMENTS = {};
* after the app has started.
*/
const MANUAL_EXPERIMENTS = {
emailFirst: BaseExperiment,
// For now, the send SMS experiment only needs to log "enrolled", so
// no special experiment is created.
signupCode: BaseExperiment,
Expand Down
46 changes: 0 additions & 46 deletions packages/fxa-content-server/app/scripts/lib/experiments/grouping-rules/email-first.js
View file
Open in desktop

This file was deleted.

1 change: 0 additions & 1 deletion packages/fxa-content-server/app/scripts/lib/experiments/grouping-rules/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,6 @@ const _ = require('underscore');
const experimentGroupingRules = [
require('./communication-prefs'),
require('./cwts-on-signup-password'),
require('./email-first'),
require('./is-sampled-user'),
require('./send-sms-install-link'),
require('./sentry'),
Expand Down
13 changes: 3 additions & 10 deletions packages/fxa-content-server/app/scripts/views/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,6 @@ import AuthErrors from '../lib/auth-errors';
import CachedCredentialsMixin from './mixins/cached-credentials-mixin';
import Cocktail from 'cocktail';
import CoppaMixin from './mixins/coppa-mixin';
import EmailFirstExperimentMixin from './mixins/email-first-experiment-mixin';
import FirefoxFamilyServicesTemplate from '../templates/partial/firefox-family-services.mustache';
import TokenCodeExperimentMixin from './mixins/token-code-experiment-mixin';
import FlowBeginMixin from './mixins/flow-begin-mixin';
Expand Down Expand Up @@ -69,19 +68,14 @@ class IndexView extends FormView {

if (isLegacySigninSignupDisabled && action !== 'force_auth') {
return this.chooseEmailActionPage();
}

if (action && action !== 'email') {
} else if (action === 'force_auth') {
this.replaceCurrentPage(action);
} else if (
this.isInEmailFirstExperimentGroup('treatment') ||
action === 'email'
) {
} else if (action) {
return this.chooseEmailActionPage();
} else if (this.getSignedInAccount().get('sessionToken')) {
this.replaceCurrentPage('settings');
} else {
this.replaceCurrentPage('signup');
return this.chooseEmailActionPage();
}
}

Expand Down Expand Up @@ -228,7 +222,6 @@ Cocktail.mixin(
IndexView,
CachedCredentialsMixin,
CoppaMixin({}),
EmailFirstExperimentMixin(),
TokenCodeExperimentMixin,
FlowBeginMixin,
FormPrefillMixin,
Expand Down
94 changes: 0 additions & 94 deletions packages/fxa-content-server/app/scripts/views/mixins/email-first-experiment-mixin.js
View file
Open in desktop

This file was deleted.

48 changes: 0 additions & 48 deletions packages/fxa-content-server/app/tests/spec/lib/experiments/grouping-rules/email-first.js
View file
Open in desktop

This file was deleted.

2 changes: 1 addition & 1 deletion packages/fxa-content-server/app/tests/spec/lib/experiments/grouping-rules/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ import sinon from 'sinon';

describe('lib/experiments/grouping-rules/index', () => {
it('EXPERIMENT_NAMES is exported', () => {
assert.lengthOf(ExperimentGroupingRules.EXPERIMENT_NAMES, 8);
assert.lengthOf(ExperimentGroupingRules.EXPERIMENT_NAMES, 7);
});

describe('choose', () => {
Expand Down
Loading