Bug 1655477 Support X-Source-Tags header #1328
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
relud
approved these changes
Aug 3, 2020
jklukas
commented
Aug 3, 2020
| @@ -42,7 +42,8 @@ | |||
|
|
|||
| private static final String HEADER = "header"; | |||
| private static final List<String> HEADER_ATTRIBUTES = ImmutableList // | |||
| .of(Attribute.DATE, Attribute.DNT, Attribute.X_PINGSENDER_VERSION, Attribute.X_DEBUG_ID); | |||
| .of(Attribute.DATE, Attribute.DNT, Attribute.X_PINGSENDER_VERSION, Attribute.X_DEBUG_ID, | |||
| Attribute.X_SOURCE_TAGS); | |||
There was a problem hiding this comment.
I'm assuming here that we'll include x_debug_id as a simple string field in BigQuery, and potentially update user-facing views to transform the string to a list. This seems cleaner than trying to parse the field to a list within the pipeline.
Codecov Report
@@ Coverage Diff @@
## master #1328 +/- ##
============================================
+ Coverage 80.80% 85.02% +4.21%
- Complexity 665 681 +16
============================================
Files 98 98
Lines 4126 4126
Branches 396 396
============================================
+ Hits 3334 3508 +174
+ Misses 663 487 -176
- Partials 129 131 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
jklukas
added a commit
to mozilla-services/mozilla-pipeline-schemas
that referenced
this pull request
Aug 3, 2020
Also see pipeline support in mozilla/gcp-ingestion#1328
4 tasks
|
For my convenience also update https://github.com/mozilla/gcp-ingestion/blob/master/ingestion-edge/ingestion_edge/config.py#L55 (EDIT: it's already there) |
jklukas
added a commit
to mozilla-services/mozilla-pipeline-schemas
that referenced
this pull request
Aug 3, 2020
Also see pipeline support in mozilla/gcp-ingestion#1328
jklukas
added a commit
that referenced
this pull request
Aug 3, 2020
Fixup to #1328 since it looks like we have this logic duplicated in core and in beam.
jklukas
added a commit
that referenced
this pull request
Aug 3, 2020
Fixup to #1328 since it looks like we have this logic duplicated in core and in beam.
relud
pushed a commit
that referenced
this pull request
Aug 3, 2020
Fixup to #1328 since it looks like we have this logic duplicated in core and in beam.
relud
pushed a commit
that referenced
this pull request
Aug 3, 2020
Fixup to #1328 since it looks like we have this logic duplicated in core and in beam.
relud
pushed a commit
that referenced
this pull request
Aug 3, 2020
Fixup to #1328 since it looks like we have this logic duplicated in core and in beam.
relud
pushed a commit
that referenced
this pull request
Aug 3, 2020
Fixup to #1328 since it looks like we have this logic duplicated in core and in beam.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Will also need a corresponding change in mozilla-pipeline-schemas (see mozilla-services/mozilla-pipeline-schemas#587).