Skip to content

Commit

Permalink
Bug 1788301 [wpt PR 35692] - Revert "webauthn: Update abort handling …
Browse files Browse the repository at this point in the history
…to take an abort reason", a=testonly

Automatic update from web-platform-tests
Revert "webauthn: Update abort handling to take an abort reason"

This reverts commit 626cf945c1cb51b2b51cf145d5be7cdaf6e2879b.

Reason for revert: crbug.com/1357180

Original change's description:
> webauthn: Update abort handling to take an abort reason
>
> AbortController now has a `reason` [1] parameter which
> has been added to Web Authentication [2], Credential Management [3],
> and Web OTP [4]. We should update CredentialsContainer to take
> this `reason` to the promise then aborting a request.
>
> [1] https://developer.mozilla.org/en-US/docs/Web/API/AbortSignal/reason
> [2] w3c/webauthn#1706
> [3] w3c/webappsec-credential-management#196
> [4] WICG/web-otp#57
>
> Bug: 1272541, 1329938
> Change-Id: Idb9ef40d6a97ae240ae3a28892a426e4c0ffbfef
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3715820
> Commit-Queue: Euisang Lim <eui-sang.lim@samsung.com>
> Commit-Queue: Nina Satragno <nsatragno@chromium.org>
> Reviewed-by: Nina Satragno <nsatragno@chromium.org>
> Cr-Commit-Position: refs/heads/main@{#1039866}

Bug: 1272541, 1329938, 1357180
Change-Id: Ida573df85179b8575b3cba725109a45a09a30507
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3861492
Auto-Submit: Francois Pierre Doray <fdoray@chromium.org>
Commit-Queue: Stephen McGruer <smcgruer@chromium.org>
Owners-Override: Francois Pierre Doray <fdoray@chromium.org>
Reviewed-by: Stephen McGruer <smcgruer@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1040433}

--

wpt-commits: a7b3cd4017c97861de7712df98a7aa9de4b659ed
wpt-pr: 35692
  • Loading branch information
fdoray authored and moz-wptsync-bot committed Sep 4, 2022
1 parent 34285a2 commit 3a142ac
Show file tree
Hide file tree
Showing 4 changed files with 0 additions and 123 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -66,12 +66,4 @@
{otp: {transport: ["sms"]}, signal: signal}));
}, 'Should abort request');

promise_test(async t => {
const controller = new AbortController();
const signal = controller.signal;

controller.abort('CustomError');
await promise_rejects_exactly(t, 'CustomError', navigator.credentials.get(
{otp: {transport: ["sms"]}, signal: signal}));
}, 'Should abort request with reason');
</script>
Original file line number Diff line number Diff line change
Expand Up @@ -41,19 +41,6 @@
.runTest('Payment credential does not allow residentKey to be "discouraged".', "NotSupportedError");
new CreatePaymentCredentialsTest({authenticatorAttachment: 'cross-platform'})
.runTest('Payment credential requires authenticatorAttachment to be "platform", not "cross-platform".', "NotSupportedError");

// abort creates
let abortController = new AbortController();
abortController.abort();
new CreatePaymentCredentialsTest()
.modify("options.signal", abortController.signal)
.runTest("Payment credential abort without reason", "AbortError");

abortController = new AbortController();
abortController.abort(new Error('error'));
new CreatePaymentCredentialsTest()
.modify("options.signal", abortController.signal)
.runTest("Payment credential abort reason with Error", Error);
}, {
protocol: 'ctap2_1',
transport: 'internal',
Expand Down

This file was deleted.

74 changes: 0 additions & 74 deletions testing/web-platform/tests/webauthn/getcredential-abort.https.html

This file was deleted.

0 comments on commit 3a142ac

Please sign in to comment.