-
Notifications
You must be signed in to change notification settings - Fork 2k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Bug 1786626 [wpt PR 35586] - Incorporate updates to pop-up UA stylesh…
…eet, a=testonly Automatic update from web-platform-tests Incorporate updates to pop-up UA stylesheet There's been pushback [1] to the !important rule on display:none, and more conversation about padding. This CL updates the behavior to keep up with the conversation. It also un-breaks several demos that were relying on the non-!important display:none rule. [1] openui/open-ui#561 (comment) Bug: 1307772 Change-Id: Ia267bf54546e433436963ae4a89d7828181c7015 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3851364 Auto-Submit: Mason Freed <masonf@chromium.org> Commit-Queue: Mason Freed <masonf@chromium.org> Reviewed-by: David Baron <dbaron@chromium.org> Cr-Commit-Position: refs/heads/main@{#1038529} -- wpt-commits: b1b8cdddc3fe9cbb5fe13fc05cbe25f6d574b6dd wpt-pr: 35586
- Loading branch information
1 parent
9860fba
commit 4a3c5aa
Showing
3 changed files
with
42 additions
and
9 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8 changes: 3 additions & 5 deletions
8
testing/web-platform/tests/html/semantics/popups/resources/popup-styles.css
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,19 +1,17 @@ | ||
.fake-pop-up { | ||
position: fixed; | ||
inset-inline-start: 0; | ||
inset-inline-end: 0; | ||
inset-block-start: 0; | ||
inset-block-end: 0; | ||
inset: 0; | ||
width: fit-content; | ||
height: fit-content; | ||
margin: auto; | ||
border: solid; | ||
padding: 0.25em; | ||
overflow: auto; | ||
color: CanvasText; | ||
background-color: Canvas; | ||
} | ||
.fake-pop-up-backdrop { | ||
position: fixed; | ||
top:0; right:0; bottom:0; left:0; | ||
inset:0; | ||
pointer-events: none !important; | ||
} |