Send text string and value array for SendKeysParameters #612
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Following https://bugzilla.mozilla.org/show_bug.cgi?id=1348782 and https://bugzilla.mozilla.org/show_bug.cgi?id=1354323, the sendKeysToElement and sendKeysToDialog commands in Marionette accept only a string `text' field as input. These patches to Firefox has since been uplifted all the way to Firefox 53. In order to make geckodriver work with newer Firefox versions again, we need to pass the `text' field. But in order to support older Firefoxen without the `text' field requirement, we also want to continue to send `value' as a string array. Clients must unfortunately send a string `text' field, but it is believed it is easier to upgrade to the latest Selenium release than to pin the exact versions of geckodriver and Firefox. Fixes: #594
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following https://bugzilla.mozilla.org/show_bug.cgi?id=1348782
and https://bugzilla.mozilla.org/show_bug.cgi?id=1354323, the
sendKeysToElement and sendKeysToDialog commands in Marionette accept
only a string `text' field as input.
These patches to Firefox has since been uplifted all the way to Firefox
53. In order to make geckodriver work with newer Firefox versions again,
we need to pass the
text' field. But in order to support older Firefoxen without thetext' field requirement, we also want to continue to send`value' as a string array.
Clients must unfortunately send a string `text' field, but it is believed
it is easier to upgrade to the latest Selenium release than to pin the
exact versions of geckodriver and Firefox.
Fixes: #594
This change is