Skip to content

Commit

Permalink
Fix storybook generation and build storybook in CI (#245)
Browse files Browse the repository at this point in the history
There is an incompatibility between storybook and the latest
version of postcss (see: storybookjs/storybook#12668) which we didn't
notice because we weren't generating the actual storybook in CI.
  • Loading branch information
wlach authored Dec 4, 2020
1 parent 9887765 commit 254db26
Show file tree
Hide file tree
Showing 6 changed files with 198 additions and 247 deletions.
1 change: 1 addition & 0 deletions .circleci/config.yml
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@ jobs:
- node/install-packages
- run: npm install
- run: npm run build
- run: npm run build-storybook
- run: npm test
python-build-and-test:
executor: python/default
Expand Down
2 changes: 2 additions & 0 deletions .eslintignore
Original file line number Diff line number Diff line change
Expand Up @@ -4,3 +4,5 @@
public/build/bundle.js
scripts/build-glean-metadata.js
src/Tailwindcss.svelte
storybook-static/*
venv/*
1 change: 1 addition & 0 deletions .gitignore
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
/node_modules/
/public/build/
/storybook-static/
venv
*.pyc
__pycache__/
Expand Down
1 change: 1 addition & 0 deletions .prettierignore
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
public/build/bundle.js
public/build/bundle.css
public/data/*
storybook-static/*
venv
Loading

0 comments on commit 254db26

Please sign in to comment.